Re: Unit tests for SLRU - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: Unit tests for SLRU
Date
Msg-id CAJ7c6TMndoALmnxAkjv70JtZ1tLf3A=tXAVeJwK53VxA0yHrFA@mail.gmail.com
Whole thread Raw
In response to Re: Unit tests for SLRU  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Unit tests for SLRU
Re: Unit tests for SLRU
List pgsql-hackers
Hi Michael,

> I have reworked that as per the attached, that provides basically the
> same coverage, going through a SQL interface for the whole thing.
> Like all the other tests of its kind, this does not use a TAP test,
> relying on a custom configuration file instead.  This still needs some
> polishing, but the basics are here.

Many thanks for the updated patch. I didn't know one can run tests
with a custom postgresql.conf without using TAP tests.

> What do you think?

It looks much better than before. I replaced strcpy() with strncpy()
and pgindent'ed the code. Other than that to me it looks ready to be
committed.

-- 
Best regards,
Aleksander Alekseev

Attachment

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: pg_basebackup's --gzip switch misbehaves
Next
From: Simon Riggs
Date:
Subject: Re: New docs chapter on Transaction Management and related changes