> On 15 Nov 2022, at 11:15, Aleksander Alekseev <aleksander@timescale.com> wrote:
>> What do you think?
>
> It looks much better than before. I replaced strcpy() with strncpy()
> and pgindent'ed the code.
+ /* write given data to the page */
+ strncpy(TestSlruCtl->shared->page_buffer[slotno], data, BLCKSZ - 1);
Would it make sense to instead use pg_pwrite to closer match the code being
tested?
> Other than that to me it looks ready to be committed.
Agreed, reading over it nothing sticks out.
--
Daniel Gustafsson https://vmware.com/
