Re: Unit tests for SLRU - Mailing list pgsql-hackers

From Pavel Borisov
Subject Re: Unit tests for SLRU
Date
Msg-id CALT9ZEEOcnYz07ADK7ceLJa8QkdixbLDFOLp0ZY4XQSTp-PDHQ@mail.gmail.com
Whole thread Raw
In response to Re: Unit tests for SLRU  (Aleksander Alekseev <aleksander@timescale.com>)
Responses Re: Unit tests for SLRU
List pgsql-hackers
Hi, Alexander!
> > I have reworked that as per the attached, that provides basically the
> > same coverage, going through a SQL interface for the whole thing.
> > Like all the other tests of its kind, this does not use a TAP test,
> > relying on a custom configuration file instead.  This still needs some
> > polishing, but the basics are here.
>
> Many thanks for the updated patch. I didn't know one can run tests
> with a custom postgresql.conf without using TAP tests.
>
> > What do you think?
>
> It looks much better than before. I replaced strcpy() with strncpy()
> and pgindent'ed the code. Other than that to me it looks ready to be
> committed.
I've looked through the patch again. I agree it looks better and can
be committed.
Mark it as RfC now.

Regards,
Pavel Borisov



pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL
Next
From: David Rowley
Date:
Subject: Re: Add palloc_aligned() to allow arbitrary power of 2 memory alignment