Re: pgindent run? - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: pgindent run?
Date
Msg-id CAEepm=0tC8jiaG-6whG1H8Sry6DFOVO49-f2keD_5rfpUdYqfA@mail.gmail.com
Whole thread Raw
In response to Re: pgindent run?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgindent run?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, Nov 29, 2017 at 9:47 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Mark Dilger <hornschnorter@gmail.com> writes:
>> I have no objection, but if the community intends to keep everything
>> indented per project standards, why is there no git hook to reject
>> improperly indented code at commit time?  I've suffered some pain
>> trying to merge code pre-global-indent-run into a branch
>> post-global-indent-run and would rather this not keep happening.
>
> I think that'd be taking it too far, especially given that the dependency
> on a typedefs list means that the git hook might have a different idea
> of what's correctly indented than the committer does.  It'd be very hard
> to debug such discrepancies and figure out what would satisfy the hook.
>
> In the end we're trying to minimize the net amount of pain involved.
> I doubt that mechanized enforcement would fall at the global minimum.

Is there no way to get reasonable indentation that doesn't depend on
that typedefs list?

-- 
Thomas Munro
http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Updated macOS start scripts
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] postgres_fdw super user checks