Postgres Pro
Downloads
Home   >   mailing lists

Re: Add regression tests for COLLATE - Mailing list pgsql-hackers

From Robins Tharakan
Subject Re: Add regression tests for COLLATE
Date
Msg-id CAEP4nAw8s2K5bpzd_FCxAWNVq988wmf6wsbyHgEZ5+n5=E81Vg@mail.gmail.com
Whole thread Raw
In response to Re: Add regression tests for COLLATE  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Add regression tests for COLLATE  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: Add regression tests for COLLATE  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
Tree view
Hi,

Please find attached the updated patch.

Fabien pointed out that currently does not check for non-trivial locales. I am still on the learning curve about LOCALEs and so, let me know if this is a show-stopper. I guess I could look at it and get back in some time with more tests as Fabien points out.

(Apologies for the delay though. An update to the patch was mostly done back in April, but since most of the other Code-Coverage patches (SCHEMA/ROLE/etc.) had no other feedback, I worked on all of them together just this week).

--
Robins Tharakan


On 12 April 2013 09:28, Michael Paquier <michael.paquier@gmail.com> wrote:



On Thu, Apr 11, 2013 at 4:14 PM, Robins Tharakan <tharakan@gmail.com> wrote:
Hi,

Please find attached a patch to take 'make check' code-coverage of COLLATE (/src/backend/commands/collationcmds) from 0% to 96%.

Any feedback is more than welcome. Also posting this to Commitfest-next.
Just by having a quick look at the patch, using object names of the type cX is too generic even if the tests are done in a private schema. Why not using a name like collate_obj_X or similar?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Fast promotion failure
Next
From: Robins Tharakan
Date:
Subject: Re: Patch to add regression tests for SCHEMA