Re: Add regression tests for COLLATE - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Add regression tests for COLLATE
Date
Msg-id CAB7nPqQuDd1bZxER=46o09cjo9W0CZsyhCHjkM1PkxQ83903dA@mail.gmail.com
Whole thread Raw
In response to Add regression tests for COLLATE  (Robins Tharakan <tharakan@gmail.com>)
Responses Re: Add regression tests for COLLATE
List pgsql-hackers



On Thu, Apr 11, 2013 at 4:14 PM, Robins Tharakan <tharakan@gmail.com> wrote:
Hi,

Please find attached a patch to take 'make check' code-coverage of COLLATE (/src/backend/commands/collationcmds) from 0% to 96%.

Any feedback is more than welcome. Also posting this to Commitfest-next.
Just by having a quick look at the patch, using object names of the type cX is too generic even if the tests are done in a private schema. Why not using a name like collate_obj_X or similar?
--
Michael

pgsql-hackers by date:

Previous
From: Kevin Grittner
Date:
Subject: Re: (auto)vacuum truncate exclusive lock
Next
From: Jeff Janes
Date:
Subject: (auto)vacuum truncate exclusive lock