On Thu, Aug 26, 2021 at 7:15 AM Greg Nancarrow <gregn4422@gmail.com> wrote:
>
> On Wed, Aug 25, 2021 at 2:22 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> >
> > Attached updated version patches. Please review them.
> >
>
> Regarding the v11-0001 patch, it looks OK to me, but I do have one point:
> In apply_dispatch(), wouldn't it be better to NOT move the error
> reporting for an invalid message type into the switch as the default
> case - because then, if you add a new message type, you won't get a
> compiler warning (when warnings are enabled) for a missing switch
> case, which is a handy way to alert you that the new message type
> needs to be added as a case to the switch.
>
Do you have any suggestions on how to achieve that without adding some
additional variable? I think it is not a very hard requirement as we
don't follow the same at other places in code.
--
With Regards,
Amit Kapila.
