Home > mailing lists

Inconsistency in Output function of MergeJoin - Mailing list pgsql-hackers

From	Amit Kapila
Subject	Inconsistency in Output function of MergeJoin
Date	September 23, 2015 12:57:04
Msg-id	CAA4eK1JX+43hJe0VFOUPEoctUxZPB0aZGJx_s4RUNqkG+=710g@mail.gmail.com Whole thread Raw
Responses	Re: Inconsistency in Output function of MergeJoin (Robert Haas <robertmhaas@gmail.com>)
List	pgsql-hackers

While working on read functions for plan nodes (required for

parallelism), it has been observed [1] by KaiGai and separately

by me that function _outMergeJoin(), appends boolean in a

slightly different way as compare to other out functions like

_outSort(). Is there a reason of doing so which is is not apparent

from code or comments?

Attached patch makes _outMergeJoin() consistent with other _out

functions which appends boolean to string.

[1] - http://www.postgresql.org/message-id/9A28C8860F777E439AA12E8AEA7694F80114956C@BPXM15GP.gisp.nec.co.jp

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Attachment

fix_outMergeJoin_inconsistency_v1.patch

pgsql-hackers by date:

Previous

From: "Shulgin, Oleksandr"
Date: 23 September 2015, 12:40:32
Subject: Re: Calculage avg. width when operator = is missing

Next

From: Amit Kapila
Date: 23 September 2015, 13:22:56
Subject: Re: Parallel Seq Scan