Thread: Inconsistency in Output function of MergeJoin

Inconsistency in Output function of MergeJoin

From
Amit Kapila
Date:
While working on read functions for plan nodes (required for
parallelism), it has been observed [1] by KaiGai and separately
by me that function _outMergeJoin(), appends boolean in a
slightly different way as compare to other out functions like
_outSort().  Is there a reason of doing so which is is not apparent
from code or comments?


Attached patch makes _outMergeJoin() consistent with other _out
functions which appends boolean to string.
Attachment

Re: Inconsistency in Output function of MergeJoin

From
Robert Haas
Date:
On Wed, Sep 23, 2015 at 5:56 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> While working on read functions for plan nodes (required for
> parallelism), it has been observed [1] by KaiGai and separately
> by me that function _outMergeJoin(), appends boolean in a
> slightly different way as compare to other out functions like
> _outSort().  Is there a reason of doing so which is is not apparent
> from code or comments?
>
> Attached patch makes _outMergeJoin() consistent with other _out
> functions which appends boolean to string.

Seems right to me.  I'll go commit this.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company