Postgres Pro
Downloads
Home   >   mailing lists

Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL
Date
Msg-id CAA4eK1+ZXLQLCKOwEzvpCJ2XXapANY66S773zMbqbUL_7LBUiQ@mail.gmail.com
Whole thread Raw
In response to Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL  (Önder Kalacı <onderkalaci@gmail.com>)
Responses RE: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL  ("shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>)
List pgsql-hackers
Tree view 
On Mon, Mar 13, 2023 at 6:26 PM Önder Kalacı <onderkalaci@gmail.com> wrote:
>
> Attaching v2
>

Can we change the comment to: "Ignore dropped and generated columns as
the publisher doesn't send those."? After your change, att =
TupleDescAttr(slot1->tts_tupleDescriptor, attrnum); is done twice in
the same function.

In test cases, let's change the comment to: "The bug was that when the
REPLICA IDENTITY FULL is used with dropped or generated columns, we
fail to apply updates and deletes.". Also, I think we don't need to
provide the email link as anyway commit message will have a link to
the discussion.

Did you check this in the back branches?

--
With Regards,
Amit Kapila.

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: Add pg_walinspect function with block info columns
Next
From: "Drouvot, Bertrand"
Date:
Subject: Re: Split index and table statistics into different types of stats