Postgres Pro
Downloads
Home   >   mailing lists

Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL - Mailing list pgsql-hackers

From Önder Kalacı
Subject Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL
Date
Msg-id CACawEhUCg-tRGzRqRq+qHaR+kPdZ=N1fP=A4_cCYd0LuNLUgnA@mail.gmail.com
Whole thread Raw
In response to RE: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL  ("shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>)
Responses Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Tree view
Hi Shi Yu,


1.
@@ -243,6 +243,17 @@ tuples_equal(TupleTableSlot *slot1, TupleTableSlot *slot2,
                Form_pg_attribute att;
                TypeCacheEntry *typentry;

+
+               Form_pg_attribute attr = TupleDescAttr(slot1->tts_tupleDescriptor, attrnum);
+

I think we can use "att" instead of a new variable. They have the same value.

ah, of course :) 
 

2.
+# The bug was that when when the REPLICA IDENTITY FULL is used with dropped

There is an extra "when".


Fixed, thanks


Attaching v2 
Attachment

pgsql-hackers by date:

Previous
From: Önder Kalacı
Date:
Subject: Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher
Next
From: Dean Rasheed
Date:
Subject: Re: Supporting MERGE on updatable views