Re: [HACKERS] Documentation improvements for partitioning - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [HACKERS] Documentation improvements for partitioning
Date
Msg-id CA+TgmoaS=kSNAMP6LCx=3dZJvoH_K+5zv+qWK-tDqB-PAZ7d9A@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Documentation improvements for partitioning  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Responses Re: [HACKERS] Documentation improvements for partitioning  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: [HACKERS] Documentation improvements for partitioning  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
List pgsql-hackers
I think you might have the titles for 0002 and 0003 backwards.

On Fri, Mar 3, 2017 at 2:51 AM, Amit Langote
<Langote_Amit_f8@lab.ntt.co.jp> wrote:
> 0002: some cosmetic fixes to create_table.sgml

I think this sentence may be unclear to some readers:

+ One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.

I think you could replace this with something like: Even if there is
no <literal>NOT NULL</> constraint on the parent, such a constraint
can still be added to individual partitions, if desired; that is, the
children can disallow nulls even if the parent allows them, but not
the other way around.

> 0003: add clarification about NOT NULL constraint on partition columns in
>       alter_table.sgml

This is about list-ifying a note, but I think we should try to
de-note-ify it.  It's a giant block of text that is not obviously more
noteworthy than the surrounding text; I think <note> should be saved
for things that particularly need to be called out.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: "Sven R. Kunze"
Date:
Subject: Re: [HACKERS] SQL/JSON in PostgreSQL
Next
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] PATCH: psql show index with type info