Re: [doc] fix a potential grammer mistake - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: [doc] fix a potential grammer mistake
Date
Msg-id BAD0CAB0-0AAF-415A-B8AE-AD774E4F0784@yesql.se
Whole thread Raw
In response to [doc] fix a potential grammer mistake  (Junwang Zhao <zhjwpku@gmail.com>)
Responses Re: [doc] fix a potential grammer mistake
List pgsql-hackers
> On 3 Aug 2022, at 10:10, Junwang Zhao <zhjwpku@gmail.com> wrote:
>
> I think in the following sentence, were should be replaced with have,
> what do you think?
>
> ```
>                        /*
> -                        * We were just issued a SAVEPOINT inside a
> transaction block.
> +                        * We have just issued a SAVEPOINT inside a
> transaction block.
>                         * Start a subtransaction.  (DefineSavepoint already did
>                         * PushTransaction, so as to have someplace to
> put the SUBBEGIN
>                         * state.)
> ```

I'm not so sure.  If I read this right the intent of the sentence is to convey
that the user has issued a SAVEPOINT to the backend, not the backend itself.  I
think the current wording is the correct one.

--
Daniel Gustafsson        https://vmware.com/




pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: Race between KeepFileRestoredFromArchive() and restartpoint
Next
From: Erikjan Rijkers
Date:
Subject: Re: [doc] fix a potential grammer mistake