Re: [doc] fix a potential grammer mistake - Mailing list pgsql-hackers

From Junwang Zhao
Subject Re: [doc] fix a potential grammer mistake
Date
Msg-id CAEG8a3LMcV4FFF-HtAE5M05UWcJS6tV8xC6aXL2GeR7rqFPihQ@mail.gmail.com
Whole thread Raw
In response to Re: [doc] fix a potential grammer mistake  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
On Wed, Aug 3, 2022 at 4:23 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 3 Aug 2022, at 10:10, Junwang Zhao <zhjwpku@gmail.com> wrote:
> >
> > I think in the following sentence, were should be replaced with have,
> > what do you think?
> >
> > ```
> >                        /*
> > -                        * We were just issued a SAVEPOINT inside a
> > transaction block.
> > +                        * We have just issued a SAVEPOINT inside a
> > transaction block.
> >                         * Start a subtransaction.  (DefineSavepoint already did
> >                         * PushTransaction, so as to have someplace to
> > put the SUBBEGIN
> >                         * state.)
> > ```
>
> I'm not so sure.  If I read this right the intent of the sentence is to convey
> that the user has issued a SAVEPOINT to the backend, not the backend itself.  I
> think the current wording is the correct one.
>

Got it, using `were` here means the backend is the receiver of the
action, not the sender.
That makes sense, thanks a lot.

> --
> Daniel Gustafsson               https://vmware.com/
>


-- 
Regards
Junwang Zhao



pgsql-hackers by date:

Previous
From: Erikjan Rijkers
Date:
Subject: Re: [doc] fix a potential grammer mistake
Next
From: Junwang Zhao
Date:
Subject: Re: [doc] fix a potential grammer mistake