Re: add "WITH OIDS" to CREATE TABLE AS - Mailing list pgsql-patches

From Neil Conway
Subject Re: add "WITH OIDS" to CREATE TABLE AS
Date
Msg-id 87r7ycoesq.fsf@mailbox.samurai.com
Whole thread Raw
In response to Re: add "WITH OIDS" to CREATE TABLE AS  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: add "WITH OIDS" to CREATE TABLE AS  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Couldn't we use SET only when we need to change the existing value?

I'm not sure what you mean. The pg_dump output will look like:

-- at the top of the dump
SET default_with_oids = false; -- or true, doesn't really matter

-- for a table that doesn't have OIDs
CREATE TABLE (...);

-- for a table that does have OIDs
SET default_with_oids = true;
CREATE TABLE (...);
SET default_with_oids = false;

The point is that in this example if all the tables in the DB have
OIDs, you'll emit two SETs for each CREATE TABLE, so what you'd really
like is to have chosen a different default to begin with.

Anyway, it's just an implementation detail: I'll definitely implement
it one way or another in time for 7.5 (unless someone else would like
to do it, in which case I'd gladly step aside).

-Neil


pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: add "WITH OIDS" to CREATE TABLE AS
Next
From: Bruce Momjian
Date:
Subject: Re: fork/exec patch: pre-CreateProcess finalization