Re: A small rant about coding style for backend functions - Mailing list pgsql-hackers

From Gregory Stark
Subject Re: A small rant about coding style for backend functions
Date
Msg-id 87abpqdpj7.fsf@oxford.xeocode.com
Whole thread Raw
In response to Re: A small rant about coding style for backend functions  ("Brendan Jurd" <direvus@gmail.com>)
Responses Re: A small rant about coding style for backend functions  (Alvaro Herrera <alvherre@commandprompt.com>)
Re: A small rant about coding style for backend functions  ("Brendan Jurd" <direvus@gmail.com>)
List pgsql-hackers
"Brendan Jurd" <direvus@gmail.com> writes:

> They are clear, useful and easy to understand.
>
> [1] http://www.python.org/dev/peps/pep-0007/
> [2] http://www.python.org/dev/peps/pep-0008/

I didn't look at the second but the first at least is a good example of a
style guide which is *not* useful. It's dominated by discussions of
white-space and other formatting issues.

The only points in this style guide which seem at all useful is the bits near
the beginning about not using GCC extensions which hardly needs stating... to
the extent that it's even true.

None of these points in here seem at all analogous to the important kind of
style details like what Tom was pointing out about using GETARG_* at the top
of your function to make the argument types clear.

--  Gregory Stark EnterpriseDB          http://www.enterprisedb.com Get trained by Bruce Momjian - ask me about
EnterpriseDB'sPostgreSQL training!
 


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Weird type selection choice
Next
From: Peter Eisentraut
Date:
Subject: interval * numeric operator