Re: doc: modify the comment in function libpqrcv_check_conninfo() - Mailing list pgsql-hackers

From ikedarintarof
Subject Re: doc: modify the comment in function libpqrcv_check_conninfo()
Date
Msg-id 7d845121f0ea99e68b4403b9cd6f86ac@oss.nttdata.com
Whole thread Raw
In response to Re: doc: modify the comment in function libpqrcv_check_conninfo()  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Responses Re: doc: modify the comment in function libpqrcv_check_conninfo()
List pgsql-hackers
> - * Validate connection info string, and determine whether it might 
> cause
> - * local filesystem access to be attempted.
> + * The function
> + * 1. validates connection info string and
> + * 2. checks a password is provided if must_use_password is true.
> 
> IMO, "Validate connection info string" is sufficient. The mention of
> must_use_password is redundant since it's explained in the latter part 
> of
> the comment.

That is reasonable for me. I've removed the second one.
The modified patch is attached.

Regards,

Rintaro Ikeda



Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Pluggable cumulative statistics
Next
From: jian he
Date:
Subject: Re: SQL:2011 application time