Re: doc: modify the comment in function libpqrcv_check_conninfo() - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: doc: modify the comment in function libpqrcv_check_conninfo()
Date
Msg-id 2faf37e9-3941-43b5-93e8-f54965b250df@oss.nttdata.com
Whole thread Raw
In response to Re: doc: modify the comment in function libpqrcv_check_conninfo()  (ikedarintarof <ikedarintarof@oss.nttdata.com>)
Responses Re: doc: modify the comment in function libpqrcv_check_conninfo()
List pgsql-hackers

On 2024/07/08 20:44, ikedarintarof wrote:
> I remove the unclear part from the previous patch and add some explanation for
>   later part of the function.

- * Validate connection info string, and determine whether it might cause
- * local filesystem access to be attempted.
+ * The function
+ * 1. validates connection info string and
+ * 2. checks a password is provided if must_use_password is true.

IMO, "Validate connection info string" is sufficient. The mention of
must_use_password is redundant since it's explained in the latter part of
the comment. Thought?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: Faster "SET search_path"
Next
From: Fujii Masao
Date:
Subject: Re: pg_wal_summary_contents() and pg_walsummary may return different results on the same WAL summary file