Re: doc: modify the comment in function libpqrcv_check_conninfo() - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: doc: modify the comment in function libpqrcv_check_conninfo()
Date
Msg-id 5899b3bf-8a34-46bb-ae75-6847828bb942@oss.nttdata.com
Whole thread Raw
In response to Re: doc: modify the comment in function libpqrcv_check_conninfo()  (ikedarintarof <ikedarintarof@oss.nttdata.com>)
List pgsql-hackers

On 2024/07/09 15:56, ikedarintarof wrote:
>> - * Validate connection info string, and determine whether it might cause
>> - * local filesystem access to be attempted.
>> + * The function
>> + * 1. validates connection info string and
>> + * 2. checks a password is provided if must_use_password is true.
>>
>> IMO, "Validate connection info string" is sufficient. The mention of
>> must_use_password is redundant since it's explained in the latter part of
>> the comment.
> 
> That is reasonable for me. I've removed the second one.
> The modified patch is attached.

Thanks for updating the patch! Pushed.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



pgsql-hackers by date:

Previous
From: Dean Rasheed
Date:
Subject: Re: Optimize numeric multiplication for one and two base-NBASE digit multiplicands.
Next
From: Junwang Zhao
Date:
Subject: Re: Address the -Wuse-after-free warning in ATExecAttachPartition()