Re: Pluggable cumulative statistics - Mailing list pgsql-hackers

On Mon, Jul 08, 2024 at 02:07:58PM +0000, Bertrand Drouvot wrote:
> It looks pretty straightforward, just one comment:
>
> +                       ptr = ((char *) ctl) + kind_info->shared_ctl_off;
> +                       kind_info->init_shmem_cb((void *) ptr);
>
> I don't think we need to cast ptr to void when calling init_shmem_cb(). Looking
> at some examples in the code, it does not look like we cast the argument to void
> when a function has (void *) as parameter (also there is examples in 0003 where
> it's not done, see next comments for 0003).

Yep.  Fine by me.

Please find attached a rebased patch set for now, to make the
CF bot happy.
--
Michael