[HACKERS] Time to change pg_regress diffs to unified by default? - Mailing list pgsql-hackers

From Andres Freund
Subject [HACKERS] Time to change pg_regress diffs to unified by default?
Date
Msg-id 20170406223103.ixihdedf6d6d4kbk@alap3.anarazel.de
Whole thread Raw
Responses Re: [HACKERS] Time to change pg_regress diffs to unified by default?  (Thomas Munro <thomas.munro@enterprisedb.com>)
Re: [HACKERS] Time to change pg_regress diffs to unified by default?  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Re: [HACKERS] Time to change pg_regress diffs to unified by default?  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: [HACKERS] Time to change pg_regress diffs to unified by default?  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Re: [HACKERS] Time to change pg_regress diffs to unified by default?  (David Rowley <david.rowley@2ndquadrant.com>)
List pgsql-hackers
Hi,

I personally, and I know of a bunch of other regular contributors, find
context diffs very hard to read.  Besides general dislike, for things
like regression test output context diffs are just not well suited.
E.g. in
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=prairiedog&dt=2017-04-06%2021%3A10%3A56&stg=check
the salient point (ERROR:  50 is outside the valid range for parameter "effective_io_concurrency" (0 .. 0))
is 130 lines into the diff, whereas it's right at the start in a unified diff.
Issues with one error that causes a lot of followup output changes are
really common in our regression suite.

I personally have PG_REGRESS_DIFF_OPTS set to -dU10, but that doesn't
help much analyzing buildfarm output.

Therefore I propose changing the defaults in pg_regress.c.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: [HACKERS] Letting the client choose the protocol to use during aSASL exchange
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Letting the client choose the protocol to use during aSASL exchange