Re: change in behaviour for format_type() call - Mailing list pgsql-hackers

From Tom Lane
Subject Re: change in behaviour for format_type() call
Date
Msg-id 16285.1519922407@sss.pgh.pa.us
Whole thread Raw
In response to Re: change in behaviour for format_type() call  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: change in behaviour for format_type() call  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Re: change in behaviour for format_type() call  (Rushabh Lathia <rushabh.lathia@gmail.com>)
List pgsql-hackers
I wrote:
> I don't see anything in the commit message or linked discussion to
> indicate that any visible behavior change was intended, so I think
> you're right, this is a bug.  Will check and push your patch.

Actually, this patch still wasn't quite right: although it fixed
one aspect of the behavior, it still produced identical results
for typemod NULL and typemod -1, which as the function's comment
explains is not what should happen.  I tweaked the logic to look
as much as possible like before, and added a regression test.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Curt Tilmes
Date:
Subject: Re: [PATCH] Find additional connection service files inpg_service.conf.d directory
Next
From: Alexander Kuzmenkov
Date:
Subject: Re: [patch] BUG #15005: ANALYZE can make pg_class.reltuplesinaccurate.