Re: change in behaviour for format_type() call - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: change in behaviour for format_type() call
Date
Msg-id 20180301175422.jk4uq6s7bqgwk6dg@alvherre.pgsql
Whole thread Raw
In response to Re: change in behaviour for format_type() call  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: change in behaviour for format_type() call  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tom Lane wrote:
> I wrote:
> > I don't see anything in the commit message or linked discussion to
> > indicate that any visible behavior change was intended, so I think
> > you're right, this is a bug.  Will check and push your patch.
> 
> Actually, this patch still wasn't quite right: although it fixed
> one aspect of the behavior, it still produced identical results
> for typemod NULL and typemod -1, which as the function's comment
> explains is not what should happen.  I tweaked the logic to look
> as much as possible like before, and added a regression test.

Thanks!

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: 2018-03 Commitfest Summary (Andres #1)
Next
From: Andres Freund
Date:
Subject: Re: [PoC PATCH] Parallel dump to /dev/null