Re: change in behaviour for format_type() call - Mailing list pgsql-hackers

From Rushabh Lathia
Subject Re: change in behaviour for format_type() call
Date
Msg-id CAGPqQf2yMSMck1BV++RiH=yRGmoO4tX8nWQ1WKBjXa-=3T3VQw@mail.gmail.com
Whole thread Raw
In response to Re: change in behaviour for format_type() call  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers


On Thu, Mar 1, 2018 at 10:10 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
I wrote:
> I don't see anything in the commit message or linked discussion to
> indicate that any visible behavior change was intended, so I think
> you're right, this is a bug.  Will check and push your patch.

Actually, this patch still wasn't quite right: although it fixed
one aspect of the behavior, it still produced identical results
for typemod NULL and typemod -1, which as the function's comment
explains is not what should happen.  I tweaked the logic to look
as much as possible like before, and added a regression test.

Thanks Tom.


Regards, 
Rushabh Lathia

pgsql-hackers by date:

Previous
From: Yoshimi Ichiyanagi
Date:
Subject: Re: [HACKERS][PATCH] Applying PMDK to WAL operations for persistent memory
Next
From: Masahiko Sawada
Date:
Subject: Re: Failed to request an autovacuum work-item in silence