Postgres Pro
Downloads
Home   >   mailing lists

Thread: Improve error reporting for few options in pg_createsubscriber

Improve error reporting for few options in pg_createsubscriber

From
vignesh C
Date:
Hi,

Currently, error reports for database, publication, subscription, and
replication slots do not include the option name. This has been
addressed by including the option name in the error messages, ensuring
consistency similar to remove option. Additionally, pg_log_error and
exit(1) have been replaced with a single pg_fatal statement which
means the same. The attached patch implements these changes.

Regards,
Vignesh
Attachment

RE: Improve error reporting for few options in pg_createsubscriber

From
"Hayato Kuroda (Fujitsu)"
Date:
Dear Vignesh,

> Currently, error reports for database, publication, subscription, and
> replication slots do not include the option name. This has been
> addressed by including the option name in the error messages, ensuring
> consistency similar to remove option.

Confirmed all error reporting in switch have its option name.

> Additionally, pg_log_error and
> exit(1) have been replaced with a single pg_fatal statement which
> means the same. The attached patch implements these changes.

I grepped source and confirmed that exit(1) just after pg_log_error()
does not exist anymore. Several lines have below style, but IIUC it is
out-of-scope of the patch.

pg_log_error();
pg_log_error_hint();
exit(1);

Best regards,
Hayato Kuroda
FUJITSU LIMITED

Re: Improve error reporting for few options in pg_createsubscriber

From
Amit Kapila
Date:
On Sat, Mar 22, 2025 at 7:26 PM vignesh C <vignesh21@gmail.com> wrote:
>
> Hi,
>
> Currently, error reports for database, publication, subscription, and
> replication slots do not include the option name. This has been
> addressed by including the option name in the error messages, ensuring
> consistency similar to remove option. Additionally, pg_log_error and
> exit(1) have been replaced with a single pg_fatal statement which
> means the same. The attached patch implements these changes.
>

A few comments:
*
pg_createsubscriber.exe -D ..\..\data_standby -d db1 -d db2 -d db1
--publication pub1 --publication pub1 -P "dbname=postgres port=5432"
-p 5444 --dry-run
pg_createsubscriber: error: database "db1" specified more than once
for --database

Even when user has used short form, we are displaying long form for
database. I suggest to use both short and long form where applicable.

*
"invalid object type \"%s\" specified for --remove". Isn't it better
to use the short form as well in this error message?

--
With Regards,
Amit Kapila.

Re: Improve error reporting for few options in pg_createsubscriber

From
vignesh C
Date:
On Fri, 4 Apr 2025 at 09:36, Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> A few comments:
> *
> pg_createsubscriber.exe -D ..\..\data_standby -d db1 -d db2 -d db1
> --publication pub1 --publication pub1 -P "dbname=postgres port=5432"
> -p 5444 --dry-run
> pg_createsubscriber: error: database "db1" specified more than once
> for --database
>
> Even when user has used short form, we are displaying long form for
> database. I suggest to use both short and long form where applicable.

Fixed this.

> *
> "invalid object type \"%s\" specified for --remove". Isn't it better
> to use the short form as well in this error message?

Fixed this.

The attached v2 version patch has the changes for the same.

Regards,
Vignesh
Attachment

Re: Improve error reporting for few options in pg_createsubscriber

From
Amit Kapila
Date:
On Fri, Apr 4, 2025 at 10:11 AM vignesh C <vignesh21@gmail.com> wrote:
>
> On Fri, 4 Apr 2025 at 09:36, Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
>
> The attached v2 version patch has the changes for the same.
>

Pushed.

--
With Regards,
Amit Kapila.