Re: Improve error reporting for few options in pg_createsubscriber - Mailing list pgsql-hackers

From vignesh C
Subject Re: Improve error reporting for few options in pg_createsubscriber
Date
Msg-id CALDaNm26TqzK8jcOmMbFJruh7JHFnVcGAtNju3DCyj3844OFeA@mail.gmail.com
Whole thread Raw
In response to Re: Improve error reporting for few options in pg_createsubscriber  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: Improve error reporting for few options in pg_createsubscriber
List pgsql-hackers
On Fri, 4 Apr 2025 at 09:36, Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> A few comments:
> *
> pg_createsubscriber.exe -D ..\..\data_standby -d db1 -d db2 -d db1
> --publication pub1 --publication pub1 -P "dbname=postgres port=5432"
> -p 5444 --dry-run
> pg_createsubscriber: error: database "db1" specified more than once
> for --database
>
> Even when user has used short form, we are displaying long form for
> database. I suggest to use both short and long form where applicable.

Fixed this.

> *
> "invalid object type \"%s\" specified for --remove". Isn't it better
> to use the short form as well in this error message?

Fixed this.

The attached v2 version patch has the changes for the same.

Regards,
Vignesh

Attachment

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Some codes refer slot()->{'slot_name'} but it is not defined
Next
From: Bertrand Drouvot
Date:
Subject: Re: Fwd: [BUG]: the walsender does not update its IO statistics until it exits