RE: Improve error reporting for few options in pg_createsubscriber - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: Improve error reporting for few options in pg_createsubscriber
Date
Msg-id OSCPR01MB14966484D047CCD6DE2D6E146F5A72@OSCPR01MB14966.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Improve error reporting for few options in pg_createsubscriber  (vignesh C <vignesh21@gmail.com>)
List pgsql-hackers
Dear Vignesh,

> Currently, error reports for database, publication, subscription, and
> replication slots do not include the option name. This has been
> addressed by including the option name in the error messages, ensuring
> consistency similar to remove option.

Confirmed all error reporting in switch have its option name.

> Additionally, pg_log_error and
> exit(1) have been replaced with a single pg_fatal statement which
> means the same. The attached patch implements these changes.

I grepped source and confirmed that exit(1) just after pg_log_error()
does not exist anymore. Several lines have below style, but IIUC it is
out-of-scope of the patch.

pg_log_error();
pg_log_error_hint();
exit(1);

Best regards,
Hayato Kuroda
FUJITSU LIMITED


pgsql-hackers by date:

Previous
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: pgoutput: comment atop rel_sync_cache_publication_cb() has an inconsistency
Next
From: vignesh C
Date:
Subject: Re: Conflict detection for multiple_unique_conflicts in logical replication