Postgres Pro
Downloads
Home   >   mailing lists

Thread: Re: Fix outdated code comments in nodeAgg.c

Re: Fix outdated code comments in nodeAgg.c

From
Richard Guo
Date:
On Sun, Feb 9, 2025 at 11:15 PM Zhang Mingli <zmlpostgres@gmail.com> wrote:
> By reading the codes in nodeAgg.c, I found that some comments are outdated.
> The comments referred to the function lookup_hash_entry(), which has been removed in commit b563594.
> I've adjusted the comments to refer to the correct function to make it clear.

LGTM.  This seems to be an oversight from 200f6100a, in which the
function lookup_hash_entry() was removed.

Thanks
Richard

Re: Fix outdated code comments in nodeAgg.c

From
Zhang Mingli
Date:
On Feb 10, 2025 at 16:45 +0800, Richard Guo <guofenglinux@gmail.com>, wrote:
On Sun, Feb 9, 2025 at 11:15 PM Zhang Mingli <zmlpostgres@gmail.com> wrote:
By reading the codes in nodeAgg.c, I found that some comments are outdated.
The comments referred to the function lookup_hash_entry(), which has been removed in commit b563594.
I've adjusted the comments to refer to the correct function to make it clear.

LGTM. This seems to be an oversight from 200f6100a, in which the
function lookup_hash_entry() was removed.

Thanks
Richard
Hi,

Thanks for review, added it to commitfest https://commitfest.postgresql.org/patch/5580/


--
Zhang Mingli
HashData

Re: Fix outdated code comments in nodeAgg.c

From
Jeff Davis
Date:
On Tue, 2025-02-18 at 20:11 +0800, Zhang Mingli wrote:
> Thanks for review, added it to
> commitfest https://commitfest.postgresql.org/patch/5580/

Committed. Thank you!

Regards,
    Jeff Davis