Postgres Pro
Downloads
Home   >   mailing lists

Re: Fix outdated code comments in nodeAgg.c - Mailing list pgsql-hackers

From Richard Guo
Subject Re: Fix outdated code comments in nodeAgg.c
Date
Msg-id CAMbWs4-u0a9XkP7xNiEuQJLBjyOb7OQf5OScyhPC0TXbDc+JXw@mail.gmail.com
Whole thread Raw
Responses Re: Fix outdated code comments in nodeAgg.c
List pgsql-hackers
Tree view 
On Sun, Feb 9, 2025 at 11:15 PM Zhang Mingli <zmlpostgres@gmail.com> wrote:
> By reading the codes in nodeAgg.c, I found that some comments are outdated.
> The comments referred to the function lookup_hash_entry(), which has been removed in commit b563594.
> I've adjusted the comments to refer to the correct function to make it clear.

LGTM.  This seems to be an oversight from 200f6100a, in which the
function lookup_hash_entry() was removed.

Thanks
Richard

pgsql-hackers by date:

Previous
From: Jakub Wartak
Date:
Subject: Re: hash_search_with_hash_value is high in "perf top" on a replica
Next
From: Andrei Lepikhov
Date:
Subject: Re: Showing applied extended statistics in explain Part 2