Postgres Pro
Downloads
Home   >   mailing lists

Re: Fix outdated code comments in nodeAgg.c - Mailing list pgsql-hackers

From Zhang Mingli
Subject Re: Fix outdated code comments in nodeAgg.c
Date
Msg-id 9b43912c-fbcd-430b-b4ea-b15df3401270@Spark
Whole thread Raw
In response to Re: Fix outdated code comments in nodeAgg.c  (Richard Guo <guofenglinux@gmail.com>)
Responses Re: Fix outdated code comments in nodeAgg.c
List pgsql-hackers
Tree view
On Feb 10, 2025 at 16:45 +0800, Richard Guo <guofenglinux@gmail.com>, wrote:
On Sun, Feb 9, 2025 at 11:15 PM Zhang Mingli <zmlpostgres@gmail.com> wrote:
By reading the codes in nodeAgg.c, I found that some comments are outdated.
The comments referred to the function lookup_hash_entry(), which has been removed in commit b563594.
I've adjusted the comments to refer to the correct function to make it clear.

LGTM. This seems to be an oversight from 200f6100a, in which the
function lookup_hash_entry() was removed.

Thanks
Richard
Hi,

Thanks for review, added it to commitfest https://commitfest.postgresql.org/patch/5580/


--
Zhang Mingli
HashData

pgsql-hackers by date:

Previous
From: Andy Fan
Date:
Subject: Why does exec_simple_query requires 2 snapshots
Next
From: Daniel Gustafsson
Date:
Subject: Re: Support a wildcard in backtrace_functions