Thread: Variable renaming in dbcommands.c

Variable renaming in dbcommands.c

From
Peter Eisentraut
Date:
In dbcommands.c function createdb(), there are several sets of very 
similar local variable names, such as "downer" and "dbowner", which is 
very confusing and error-prone.  The first set are the DefElem nodes 
from the parser, the second set are the local variables with the values 
extracted from them.  This patch renames the former to "ownerEl" and so 
on, similar to collationcmds.c and typecmds.c, to improve clarity.
Attachment

Re: Variable renaming in dbcommands.c

From
Daniel Gustafsson
Date:
> On 9 Aug 2024, at 09:21, Peter Eisentraut <peter@eisentraut.org> wrote:

> In dbcommands.c function createdb(), there are several sets of very similar local variable names, such as "downer"
and"dbowner", which is very confusing and error-prone.  The first set are the DefElem nodes from the parser, the second
setare the local variables with the values extracted from them.  This patch renames the former to "ownerEl" and so on,
similarto collationcmds.c and typecmds.c, to improve clarity. 

No objections, patch LGTM.

--
Daniel Gustafsson