Postgres Pro
Downloads
Home   >   mailing lists

Re: Variable renaming in dbcommands.c - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Variable renaming in dbcommands.c
Date
Msg-id 27317B09-4813-4D36-B704-57BDE2786CA9@yesql.se
Whole thread Raw
In response to Variable renaming in dbcommands.c  (Peter Eisentraut <peter@eisentraut.org>)
List pgsql-hackers
Tree view 
> On 9 Aug 2024, at 09:21, Peter Eisentraut <peter@eisentraut.org> wrote:

> In dbcommands.c function createdb(), there are several sets of very similar local variable names, such as "downer"
and"dbowner", which is very confusing and error-prone.  The first set are the DefElem nodes from the parser, the second
setare the local variables with the values extracted from them.  This patch renames the former to "ownerEl" and so on,
similarto collationcmds.c and typecmds.c, to improve clarity. 

No objections, patch LGTM.

--
Daniel Gustafsson

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Variable renaming in dbcommands.c
Next
From: Michael Banck
Date:
Subject: Improve error message for ICU libraries if pkg-config is absent