Re: Variable renaming in dbcommands.c - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Variable renaming in dbcommands.c
Date
Msg-id e2d87e67-e889-4768-b07e-181aef299086@eisentraut.org
Whole thread Raw
In response to Re: Variable renaming in dbcommands.c  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
On 09.08.24 09:43, Daniel Gustafsson wrote:
>> On 9 Aug 2024, at 09:21, Peter Eisentraut <peter@eisentraut.org> wrote:
> 
>> In dbcommands.c function createdb(), there are several sets of very similar local variable names, such as "downer"
and"dbowner", which is very confusing and error-prone.  The first set are the DefElem nodes from the parser, the second
setare the local variables with the values extracted from them.  This patch renames the former to "ownerEl" and so on,
similarto collationcmds.c and typecmds.c, to improve clarity.
 
> 
> No objections, patch LGTM.

committed




pgsql-hackers by date:

Previous
From: "Joel Jacobson"
Date:
Subject: Re: [PATCH] Add get_bytes() and set_bytes() functions
Next
From: jian he
Date:
Subject: Re: Remove dependence on integer wrapping