Thread: patch: Add missing descriptions for rmgr APIs

Hi hackers,

While reading codes related with logical decoding,
I thought that following comment in rmgrlist.h is not consistent.

> /* symbol name, textual name, redo, desc, identify, startup, cleanup */

This comment describes a set of APIs that the resource manager should have, but functions for {mask, decode} are missed
here.

Did we have any reasons for that? I thought it might be not friendly, so I attached a patch.


Best Regards,
Hayato Kuroda
FUJITSU LIMITED

On Mon, Aug 29, 2022 at 8:48 AM kuroda.hayato@fujitsu.com
<kuroda.hayato@fujitsu.com> wrote:
>
> Hi hackers,
>
> While reading codes related with logical decoding,
> I thought that following comment in rmgrlist.h is not consistent.
>
> > /* symbol name, textual name, redo, desc, identify, startup, cleanup */
>
> This comment describes a set of APIs that the resource manager should have, but functions for {mask, decode} are
missedhere.
 
>

Your observation seems correct to me but you have not updated the
comment for the mask. Is there a reason for the same?

-- 
With Regards,
Amit Kapila.

> Your observation seems correct to me but you have not updated the
> comment for the mask. Is there a reason for the same?

Oh, it seems that I attached wrong one. There is no reason.
PSA the newer version.

Best Regards,
Hayato Kuroda
FUJITSU LIMITED

On Mon, Aug 29, 2022 at 6:19 PM kuroda.hayato@fujitsu.com
<kuroda.hayato@fujitsu.com> wrote:
>
> > Your observation seems correct to me but you have not updated the
> > comment for the mask. Is there a reason for the same?
>
> Oh, it seems that I attached wrong one. There is no reason.
> PSA the newer version.
>

LGTM. Pushed.

-- 
With Regards,
Amit Kapila.