Re: patch: Add missing descriptions for rmgr APIs - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: patch: Add missing descriptions for rmgr APIs
Date
Msg-id CAA4eK1KxjhVG35MmBPg3ggkMr1nz21ewr5c_DbVcMmOCzBSKMg@mail.gmail.com
Whole thread Raw
In response to patch: Add missing descriptions for rmgr APIs  ("kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>)
Responses RE: patch: Add missing descriptions for rmgr APIs
List pgsql-hackers
On Mon, Aug 29, 2022 at 8:48 AM kuroda.hayato@fujitsu.com
<kuroda.hayato@fujitsu.com> wrote:
>
> Hi hackers,
>
> While reading codes related with logical decoding,
> I thought that following comment in rmgrlist.h is not consistent.
>
> > /* symbol name, textual name, redo, desc, identify, startup, cleanup */
>
> This comment describes a set of APIs that the resource manager should have, but functions for {mask, decode} are
missedhere.
 
>

Your observation seems correct to me but you have not updated the
comment for the mask. Is there a reason for the same?

-- 
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Handle infinite recursion in logical replication setup
Next
From: Anton Voloshin
Date:
Subject: Re: Make #else/#endif comments more consistent