Postgres Pro
Downloads
Home   >   mailing lists

Thread: [PATCH] Add support to table_to_xmlschema regex when timestamp has time zone

[PATCH] Add support to table_to_xmlschema regex when timestamp has time zone

From
Renan Soares Lopes
Date:
Hello,

I added a patch to fix table_to_xmlschema, could you point me how to add a unit test to that?
Attachment

Re: [PATCH] Add support to table_to_xmlschema regex when timestamp has time zone

From
"Euler Taveira"
Date:
On Fri, Feb 18, 2022, at 2:47 PM, Renan Soares Lopes wrote:
Hello,

I added a patch to fix table_to_xmlschema, could you point me how to add a unit test to that?
You should edit src/test/regress/expected/xmlmap.out. In this case, you should
also modify src/test/regress/expected/xmlmap_1.out that the output from this
test when you build without libxml support. Run 'make check' to test your fix
after building with/without libxml support.

Regarding this fix, it looks good to me. FWIW, character class escape is
defined here [1].



--
Euler Taveira
EDB   https://www.enterprisedb.com/

Re: [PATCH] Add support to table_to_xmlschema regex when timestamp has time zone

From
Tom Lane
Date:
"Euler Taveira" <euler@eulerto.com> writes:
> On Fri, Feb 18, 2022, at 2:47 PM, Renan Soares Lopes wrote:
>> I added a patch to fix table_to_xmlschema, could you point me how to add a unit test to that?

> You should edit src/test/regress/expected/xmlmap.out. In this case, you should
> also modify src/test/regress/expected/xmlmap_1.out that the output from this
> test when you build without libxml support. Run 'make check' to test your fix
> after building with/without libxml support.

> Regarding this fix, it looks good to me. FWIW, character class escape is
> defined here [1].

LGTM too.  Pushed after rethinking the test case a bit.

            regards, tom lane