Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Add support to table_to_xmlschema regex when timestamp has time zone - Mailing list pgsql-hackers

From Euler Taveira
Subject Re: [PATCH] Add support to table_to_xmlschema regex when timestamp has time zone
Date
Msg-id 1bcdc383-9856-4ddd-b975-d728a4f687c7@www.fastmail.com
Whole thread Raw
In response to [PATCH] Add support to table_to_xmlschema regex when timestamp has time zone  (Renan Soares Lopes <renans.l@icloud.com>)
Responses Re: [PATCH] Add support to table_to_xmlschema regex when timestamp has time zone  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view
On Fri, Feb 18, 2022, at 2:47 PM, Renan Soares Lopes wrote:
Hello,

I added a patch to fix table_to_xmlschema, could you point me how to add a unit test to that?
You should edit src/test/regress/expected/xmlmap.out. In this case, you should
also modify src/test/regress/expected/xmlmap_1.out that the output from this
test when you build without libxml support. Run 'make check' to test your fix
after building with/without libxml support.

Regarding this fix, it looks good to me. FWIW, character class escape is
defined here [1].



--
Euler Taveira
EDB   https://www.enterprisedb.com/

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: adding 'zstd' as a compression algorithm
Next
From: Joe Conway
Date:
Subject: Re: Time to drop plpython2?