Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Add support to table_to_xmlschema regex when timestamp has time zone - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Add support to table_to_xmlschema regex when timestamp has time zone
Date
Msg-id 1221363.1647633769@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Add support to table_to_xmlschema regex when timestamp has time zone  ("Euler Taveira" <euler@eulerto.com>)
List pgsql-hackers
Tree view 
"Euler Taveira" <euler@eulerto.com> writes:
> On Fri, Feb 18, 2022, at 2:47 PM, Renan Soares Lopes wrote:
>> I added a patch to fix table_to_xmlschema, could you point me how to add a unit test to that?

> You should edit src/test/regress/expected/xmlmap.out. In this case, you should
> also modify src/test/regress/expected/xmlmap_1.out that the output from this
> test when you build without libxml support. Run 'make check' to test your fix
> after building with/without libxml support.

> Regarding this fix, it looks good to me. FWIW, character class escape is
> defined here [1].

LGTM too.  Pushed after rethinking the test case a bit.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: pgsql: Add option to use ICU as global locale provider
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Add option to use ICU as global locale provider