Thread: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React.
[pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React.
From
Yogesh Mahajan
Date:
Hi Hackers,
Please find the patch which port import/export data dialogue to react.
Thanks,
Yogesh Mahajan
EnterpriseDB
Attachment
Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React.
From
Akshay Joshi
Date:
Hi Yogesh
Following are the review comments:
- Increase the height of the dialog to avoid the scroll bars. Check the height of the backup dialog.
- The 'OK' button should be disabled and the validation message 'Please provide a file name.' should be shown the first time when the dialog is opened. Check backup dialog
- The help button should be enabled and check it refers to the appropriate page.
- Update the documentation and screenshots.
On Wed, Jan 19, 2022 at 12:52 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi Hackers,Please find the patch which port import/export data dialogue to react.Thanks,Yogesh MahajanEnterpriseDB
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB PostgresMobile: +91 976-788-8246
Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React.
From
Yogesh Mahajan
Date:
Hi,
Please find the attached patch which fixes all comments given below.
Thanks,
Yogesh Mahajan
EnterpriseDB
On Wed, Jan 19, 2022 at 7:47 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi YogeshFollowing are the review comments:
- Increase the height of the dialog to avoid the scroll bars. Check the height of the backup dialog.
- The 'OK' button should be disabled and the validation message 'Please provide a file name.' should be shown the first time when the dialog is opened. Check backup dialog
- The help button should be enabled and check it refers to the appropriate page.
- Update the documentation and screenshots.
On Wed, Jan 19, 2022 at 12:52 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:Hi Hackers,Please find the patch which port import/export data dialogue to react.Thanks,Yogesh MahajanEnterpriseDB--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246
Attachment
Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React.
From
Akshay Joshi
Date:
Thanks, the patch applied.
On Thu, Jan 20, 2022 at 3:18 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi,Please find the attached patch which fixes all comments given below.Thanks,Yogesh MahajanEnterpriseDBOn Wed, Jan 19, 2022 at 7:47 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi YogeshFollowing are the review comments:
- Increase the height of the dialog to avoid the scroll bars. Check the height of the backup dialog.
- The 'OK' button should be disabled and the validation message 'Please provide a file name.' should be shown the first time when the dialog is opened. Check backup dialog
- The help button should be enabled and check it refers to the appropriate page.
- Update the documentation and screenshots.
On Wed, Jan 19, 2022 at 12:52 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:Hi Hackers,Please find the patch which port import/export data dialogue to react.Thanks,Yogesh MahajanEnterpriseDB--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB PostgresMobile: +91 976-788-8246
Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React.
From
Yogesh Mahajan
Date:
Hello Team,
Please find the attached patch which fixes the issue of duplicate values shown in Column>Columns to Import/Export dropdown when a value(values) is unselected.
Thanks,
Yogesh Mahajan
EnterpriseDB
On Fri, Jan 21, 2022 at 11:52 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, the patch applied.On Thu, Jan 20, 2022 at 3:18 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:Hi,Please find the attached patch which fixes all comments given below.Thanks,Yogesh MahajanEnterpriseDBOn Wed, Jan 19, 2022 at 7:47 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi YogeshFollowing are the review comments:
- Increase the height of the dialog to avoid the scroll bars. Check the height of the backup dialog.
- The 'OK' button should be disabled and the validation message 'Please provide a file name.' should be shown the first time when the dialog is opened. Check backup dialog
- The help button should be enabled and check it refers to the appropriate page.
- Update the documentation and screenshots.
On Wed, Jan 19, 2022 at 12:52 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:Hi Hackers,Please find the patch which port import/export data dialogue to react.Thanks,Yogesh MahajanEnterpriseDB--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246
Attachment
Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React.
From
Akshay Joshi
Date:
Thanks, the patch applied.
On Thu, Jan 27, 2022 at 1:24 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hello Team,Please find the attached patch which fixes the issue of duplicate values shown in Column>Columns to Import/Export dropdown when a value(values) is unselected.Thanks,Yogesh MahajanEnterpriseDBOn Fri, Jan 21, 2022 at 11:52 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Thanks, the patch applied.On Thu, Jan 20, 2022 at 3:18 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:Hi,Please find the attached patch which fixes all comments given below.Thanks,Yogesh MahajanEnterpriseDBOn Wed, Jan 19, 2022 at 7:47 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi YogeshFollowing are the review comments:
- Increase the height of the dialog to avoid the scroll bars. Check the height of the backup dialog.
- The 'OK' button should be disabled and the validation message 'Please provide a file name.' should be shown the first time when the dialog is opened. Check backup dialog
- The help button should be enabled and check it refers to the appropriate page.
- Update the documentation and screenshots.
On Wed, Jan 19, 2022 at 12:52 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:Hi Hackers,Please find the patch which port import/export data dialogue to react.Thanks,Yogesh MahajanEnterpriseDB--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB PostgresMobile: +91 976-788-8246