Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React. - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React.
Date
Msg-id CANxoLDcTS4VFmvrTbNriT3DS6ZwL0fUE5K6VLUBEgZtmxMgvSA@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React.  (Yogesh Mahajan <yogesh.mahajan@enterprisedb.com>)
Responses Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React.
List pgadmin-hackers
Thanks, the patch applied.

On Thu, Jan 20, 2022 at 3:18 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi, 

Please find the attached patch which fixes all comments given below.

Thanks,
Yogesh Mahajan
EnterpriseDB


On Wed, Jan 19, 2022 at 7:47 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Yogesh

Following are the review comments:
  • Increase the height of the dialog to avoid the scroll bars. Check the height of the backup dialog.
  • The 'OK' button should be disabled and the validation message 'Please provide a file name.'  should be shown the first time when the dialog is opened. Check backup dialog
  • The help button should be enabled and check it refers to the appropriate page.
  • Update the documentation and screenshots.

On Wed, Jan 19, 2022 at 12:52 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi Hackers,

Please find the patch which port import/export data dialogue to react.
Thanks,
Yogesh Mahajan
EnterpriseDB


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Port Import/Export dialog to React. Fixes #7017.
Next
From: Nikhil Mohite
Date:
Subject: [pgAdmin]: Remove "Move objects to..." option from tablespaces sub-node