Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React. - Mailing list pgadmin-hackers

From Yogesh Mahajan
Subject Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React.
Date
Msg-id CAMa=N=Pp89zQOTavVQUSoA5VYsU2dmd=wBP5Sw4RLF=dCU_7nQ@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React.  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React.  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi, 

Please find the attached patch which fixes all comments given below.

Thanks,
Yogesh Mahajan
EnterpriseDB


On Wed, Jan 19, 2022 at 7:47 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Yogesh

Following are the review comments:
  • Increase the height of the dialog to avoid the scroll bars. Check the height of the backup dialog.
  • The 'OK' button should be disabled and the validation message 'Please provide a file name.'  should be shown the first time when the dialog is opened. Check backup dialog
  • The help button should be enabled and check it refers to the appropriate page.
  • Update the documentation and screenshots.

On Wed, Jan 19, 2022 at 12:52 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi Hackers,

Please find the patch which port import/export data dialogue to react.
Thanks,
Yogesh Mahajan
EnterpriseDB


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Attachment

pgadmin-hackers by date:

Previous
From: Aditya Toshniwal
Date:
Subject: Re: [pgAdmin][RM7016]: Port Dependent, dependencies, statistics panel to React.
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fixed code smell reported by SonarQube.