Postgres Pro
Downloads
Home   >   mailing lists

Thread: a comment in joinrel.c: compute_partition_bounds()

a comment in joinrel.c: compute_partition_bounds()

From
Amit Langote
Date:
Hi,

I think there's a word missing in the following comment:

        /*
         * See if the partition bounds for inputs are exactly the same, in
         * which case we don't need to work hard: the join rel have the same
         * partition bounds as inputs, and the partitions with the same
         * cardinal positions form the pairs.

": the join rel have the same..." seems to be missing a "will".

Attached a patch to fix.

-- 
Amit Langote
EDB: http://www.enterprisedb.com
Attachment

Re: a comment in joinrel.c: compute_partition_bounds()

From
Etsuro Fujita
Date:
Hi Amit-san,

On Fri, Sep 24, 2021 at 3:34 PM Amit Langote <amitlangote09@gmail.com> wrote:
> I think there's a word missing in the following comment:
>
>         /*
>          * See if the partition bounds for inputs are exactly the same, in
>          * which case we don't need to work hard: the join rel have the same
>          * partition bounds as inputs, and the partitions with the same
>          * cardinal positions form the pairs.
>
> ": the join rel have the same..." seems to be missing a "will".
>
> Attached a patch to fix.

Good catch!  Will fix.

Thanks!

Best regards,
Etsuro Fujita

Re: a comment in joinrel.c: compute_partition_bounds()

From
Etsuro Fujita
Date:
On Fri, Sep 24, 2021 at 4:20 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> On Fri, Sep 24, 2021 at 3:34 PM Amit Langote <amitlangote09@gmail.com> wrote:
> > I think there's a word missing in the following comment:
> >
> >         /*
> >          * See if the partition bounds for inputs are exactly the same, in
> >          * which case we don't need to work hard: the join rel have the same
> >          * partition bounds as inputs, and the partitions with the same
> >          * cardinal positions form the pairs.
> >
> > ": the join rel have the same..." seems to be missing a "will".
> >
> > Attached a patch to fix.
>
> Good catch!  Will fix.

Rereading the comment, I think it would be better to add “will” to the
second part “the partitions with the same cardinal positions form the
pairs” as well.  Updated patch attached.

Best regards,
Etsuro Fujita
Attachment

Re: a comment in joinrel.c: compute_partition_bounds()

From
Amit Langote
Date:
Fujita-san,

On Wed, Oct 6, 2021 at 5:41 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> On Fri, Sep 24, 2021 at 4:20 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> > On Fri, Sep 24, 2021 at 3:34 PM Amit Langote <amitlangote09@gmail.com> wrote:
> > > I think there's a word missing in the following comment:
> > >
> > >         /*
> > >          * See if the partition bounds for inputs are exactly the same, in
> > >          * which case we don't need to work hard: the join rel have the same
> > >          * partition bounds as inputs, and the partitions with the same
> > >          * cardinal positions form the pairs.
> > >
> > > ": the join rel have the same..." seems to be missing a "will".
> > >
> > > Attached a patch to fix.
> >
> > Good catch!  Will fix.
>
> Rereading the comment, I think it would be better to add “will” to the
> second part “the partitions with the same cardinal positions form the
> pairs” as well.  Updated patch attached.

No objection from my side.

Thank you.

--
Amit Langote
EDB: http://www.enterprisedb.com

Re: a comment in joinrel.c: compute_partition_bounds()

From
Etsuro Fujita
Date:
On Thu, Oct 7, 2021 at 12:05 PM Amit Langote <amitlangote09@gmail.com> wrote:
> On Wed, Oct 6, 2021 at 5:41 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> > Rereading the comment, I think it would be better to add “will” to the
> > second part “the partitions with the same cardinal positions form the
> > pairs” as well.  Updated patch attached.
>
> No objection from my side.

Ok, pushed.  Thanks!

Best regards,
Etsuro Fujita