Re: a comment in joinrel.c: compute_partition_bounds() - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: a comment in joinrel.c: compute_partition_bounds()
Date
Msg-id CAPmGK168z05usEDecauLc3iBz6pPGYZJY4SMe+56JDZHtSFC+g@mail.gmail.com
Whole thread Raw
In response to a comment in joinrel.c: compute_partition_bounds()  (Amit Langote <amitlangote09@gmail.com>)
Responses Re: a comment in joinrel.c: compute_partition_bounds()  (Etsuro Fujita <etsuro.fujita@gmail.com>)
List pgsql-hackers
Hi Amit-san,

On Fri, Sep 24, 2021 at 3:34 PM Amit Langote <amitlangote09@gmail.com> wrote:
> I think there's a word missing in the following comment:
>
>         /*
>          * See if the partition bounds for inputs are exactly the same, in
>          * which case we don't need to work hard: the join rel have the same
>          * partition bounds as inputs, and the partitions with the same
>          * cardinal positions form the pairs.
>
> ": the join rel have the same..." seems to be missing a "will".
>
> Attached a patch to fix.

Good catch!  Will fix.

Thanks!

Best regards,
Etsuro Fujita



pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: row filtering for logical replication
Next
From: Dilip Kumar
Date:
Subject: Re: Gather performance analysis