Thread: Re: BUG #16345: ts_headline does not find phrase matches correctly
redirected to hackers.
On Wed, Apr 8, 2020 at 11:02 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
In short then, I propose applying 0001-0006. I'm not quite sure
if we should back-patch, or just be content to fix this in HEAD.
But there's definitely an argument that this has been broken since
we added phrase search (in 9.6) and deserves to be back-patched.
Thanks for fixing this.
I am getting a compiler warning, both with and without --enable-cassert.
wparser_def.c:2530:2: warning: 'pose' may be used uninitialized in this function [-Wmaybe-uninitialized]
mark_fragment(prs, highlightall, bestb, beste);
^
wparser_def.c:2384:6: note: 'pose' was declared here
int pose,
It makes no sense to me that pose could be used uninitialized on a line that doesn't use pose at all, so maybe it is a compiler bug or something.
PostgreSQL 13devel-c9b0c67 on x86_64-pc-linux-gnu, compiled by gcc (Ubuntu 5.4.0-6ubuntu1~16.04.12) 5.4.0 20160609, 64-bit
Cheers,
Jeff
Jeff Janes <jeff.janes@gmail.com> writes:
> I am getting a compiler warning, both with and without --enable-cassert.
> wparser_def.c: In function 'prsd_headline':
> wparser_def.c:2530:2: warning: 'pose' may be used uninitialized in this
> function [-Wmaybe-uninitialized]
> mark_fragment(prs, highlightall, bestb, beste);
> ^
> wparser_def.c:2384:6: note: 'pose' was declared here
> int pose,
I see it too, now that I try a different compiler version. Will fix.
> It makes no sense to me that pose could be used uninitialized on a line
> that doesn't use pose at all, so maybe it is a compiler bug or something.
It looks like the compiler is doing aggressive inlining, which might
have something to do with the crummy error report placement. Notice
that this isn't inside 'prsd_headline' at all, so far as the source code
is concerned.
regards, tom lane