Re: BUG #16345: ts_headline does not find phrase matches correctly - Mailing list pgsql-hackers

From Jeff Janes
Subject Re: BUG #16345: ts_headline does not find phrase matches correctly
Date
Msg-id CAMkU=1zqTNcxWzFwuRMhJpc5d_q2+j3TbFXiee4PmuGLP0LVnA@mail.gmail.com
Whole thread Raw
Responses Re: BUG #16345: ts_headline does not find phrase matches correctly  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers


redirected to hackers.

On Wed, Apr 8, 2020 at 11:02 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:

In short then, I propose applying 0001-0006.  I'm not quite sure
if we should back-patch, or just be content to fix this in HEAD.
But there's definitely an argument that this has been broken since
we added phrase search (in 9.6) and deserves to be back-patched.


Thanks for fixing this.  

I am getting a compiler warning, both with and without --enable-cassert.

wparser_def.c: In function 'prsd_headline':
wparser_def.c:2530:2: warning: 'pose' may be used uninitialized in this function [-Wmaybe-uninitialized]
  mark_fragment(prs, highlightall, bestb, beste);
  ^
wparser_def.c:2384:6: note: 'pose' was declared here
  int   pose,


It makes no sense to me that pose could be used uninitialized on a line that doesn't use pose at all, so maybe it is a compiler bug or something.

PostgreSQL 13devel-c9b0c67 on x86_64-pc-linux-gnu, compiled by gcc (Ubuntu 5.4.0-6ubuntu1~16.04.12) 5.4.0 20160609, 64-bit

Cheers,

Jeff

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: more ALTER .. DEPENDS ON EXTENSION fixes
Next
From: Andres Freund
Date:
Subject: Re: Parallel copy