Thread: commit message

commit message

From
Fujii Masao
Date:
Hi,

When I pushed the patch "pgsql: Prevent archive recovery from scanning
non-existent WAL files.", I received the following email and mistakenly
clicked the link for the cancel. So no message for that commit was not sent
to pgsql-committers. Could you revive the commit message?
Sorry for my mistake...

BTW, this is the first time when I received the following email when I pushed
the commit. So something changed in pgsql-committers ML recently?

------------------------------------------
Your message to pgsql-committers with subject
"pgsql: Prevent archive recovery from scanning non-existent WAL files."
has been held for moderation.

It will be delivered to the list recipients as soon as it has been
approved by a moderator.

If you wish to cancel the message without delivery, please click
this link:
xxxxxxxxxxxxxxxxxxxxxxxxxxxxx
------------------------------------------

Regards,

-- 
Fujii Masao



Re: commit message

From
Magnus Hagander
Date:
On Tue, Apr 7, 2020 at 6:04 PM Fujii Masao <masao.fujii@gmail.com> wrote:
>
> Hi,
>
> When I pushed the patch "pgsql: Prevent archive recovery from scanning
> non-existent WAL files.", I received the following email and mistakenly
> clicked the link for the cancel. So no message for that commit was not sent
> to pgsql-committers. Could you revive the commit message?
> Sorry for my mistake...

Hi!

Once you've clicked the cancel message it is, unfortunately, lost forever.

> BTW, this is the first time when I received the following email when I pushed
> the commit. So something changed in pgsql-committers ML recently?

If the address you are using for your commits is not subscribed to the
list, it will at regular intervals "expire", and a moderator must add
it back to the whitelist. I think it's once per year. This happened,
perthe logs, almost exactly 3 hours before you made the commit...

The long term fix for this is to allow you to subscribe more than one
address to the list, and then set one of them to not receive email.
The second part exists, but not the allowance to subscribe more than
one address, but we do have that on the TODO.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/



Re: commit message

From
Fujii Masao
Date:
On Wed, Apr 8, 2020 at 1:10 AM Magnus Hagander <magnus@hagander.net> wrote:
>
> On Tue, Apr 7, 2020 at 6:04 PM Fujii Masao <masao.fujii@gmail.com> wrote:
> >
> > Hi,
> >
> > When I pushed the patch "pgsql: Prevent archive recovery from scanning
> > non-existent WAL files.", I received the following email and mistakenly
> > clicked the link for the cancel. So no message for that commit was not sent
> > to pgsql-committers. Could you revive the commit message?
> > Sorry for my mistake...
>
> Hi!
>
> Once you've clicked the cancel message it is, unfortunately, lost forever.

Oh... So I will sent the commit message to pgsql-committers manually.
Thanks for the answer!

> > BTW, this is the first time when I received the following email when I pushed
> > the commit. So something changed in pgsql-committers ML recently?
>
> If the address you are using for your commits is not subscribed to the
> list, it will at regular intervals "expire", and a moderator must add
> it back to the whitelist. I think it's once per year. This happened,
> perthe logs, almost exactly 3 hours before you made the commit...
>
> The long term fix for this is to allow you to subscribe more than one
> address to the list, and then set one of them to not receive email.
> The second part exists, but not the allowance to subscribe more than
> one address, but we do have that on the TODO.

Understood.

Regards,

-- 
Fujii Masao



Re: commit message

From
Fujii Masao
Date:

On 2020/04/08 1:23, Fujii Masao wrote:
> On Wed, Apr 8, 2020 at 1:10 AM Magnus Hagander <magnus@hagander.net> wrote:
>>
>> On Tue, Apr 7, 2020 at 6:04 PM Fujii Masao <masao.fujii@gmail.com> wrote:
>>>
>>> Hi,
>>>
>>> When I pushed the patch "pgsql: Prevent archive recovery from scanning
>>> non-existent WAL files.", I received the following email and mistakenly
>>> clicked the link for the cancel. So no message for that commit was not sent
>>> to pgsql-committers. Could you revive the commit message?
>>> Sorry for my mistake...
>>
>> Hi!
>>
>> Once you've clicked the cancel message it is, unfortunately, lost forever.
> 
> Oh... So I will sent the commit message to pgsql-committers manually.
> Thanks for the answer!
> 
>>> BTW, this is the first time when I received the following email when I pushed
>>> the commit. So something changed in pgsql-committers ML recently?
>>
>> If the address you are using for your commits is not subscribed to the
>> list, it will at regular intervals "expire", and a moderator must add
>> it back to the whitelist. I think it's once per year. This happened,
>> perthe logs, almost exactly 3 hours before you made the commit...

Could you add my address to use for the commit, back to the whitelist?
Or could you approve the messages of the commits that I pushed?
Today I received the following three "Message to pgsql-committers held for moderation" mails.

--------------------------
Your message to pgsql-committers with subject
"pgsql: Add note in pg_stat_statements documentation about planning stat"
has been held for moderation.

Your message to pgsql-committers with subject
"pgsql: Exclude backup_manifest file that existed in database, from BASE"
has been held for moderation.

Your message to pgsql-committers with subject
"pgsql: Fix typo in pg_validatebackup documentation."
has been held for moderation.
--------------------------

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



Re: commit message

From
Fujii Masao
Date:

On 2020/04/09 22:57, Fujii Masao wrote:
> 
> 
> On 2020/04/08 1:23, Fujii Masao wrote:
>> On Wed, Apr 8, 2020 at 1:10 AM Magnus Hagander <magnus@hagander.net> wrote:
>>>
>>> On Tue, Apr 7, 2020 at 6:04 PM Fujii Masao <masao.fujii@gmail.com> wrote:
>>>>
>>>> Hi,
>>>>
>>>> When I pushed the patch "pgsql: Prevent archive recovery from scanning
>>>> non-existent WAL files.", I received the following email and mistakenly
>>>> clicked the link for the cancel. So no message for that commit was not sent
>>>> to pgsql-committers. Could you revive the commit message?
>>>> Sorry for my mistake...
>>>
>>> Hi!
>>>
>>> Once you've clicked the cancel message it is, unfortunately, lost forever.
>>
>> Oh... So I will sent the commit message to pgsql-committers manually.
>> Thanks for the answer!
>>
>>>> BTW, this is the first time when I received the following email when I pushed
>>>> the commit. So something changed in pgsql-committers ML recently?
>>>
>>> If the address you are using for your commits is not subscribed to the
>>> list, it will at regular intervals "expire", and a moderator must add
>>> it back to the whitelist. I think it's once per year. This happened,
>>> perthe logs, almost exactly 3 hours before you made the commit...
> 
> Could you add my address to use for the commit, back to the whitelist?
> Or could you approve the messages of the commits that I pushed?
> Today I received the following three "Message to pgsql-committers held for moderation" mails.

Stephen did them and I saw that three commit messages were delivered to
pgsql-committers. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION