Thread: [pgAdmin4][RM 5271] To change the switch control colors
Attachment
Hi Murtuza,
The changes are already incorporated so no worries :)
Thanks,
---
Chethana kumar
On Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hello,As per discussion with Chethana, We need to make switch box color change for light and dark theme, Color details provided by Chethana is updated on ticket.--Regards,
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation
The Postgres Database Company
P: +91 86981 57146
Hi Chethana,
No it is not, As per current dark theme implementation we have used primary color '#1a522b' for switch but the color you suggested is '#43A047' for both theme.
--
Regards,
On Wed, Mar 18, 2020 at 2:06 PM Chethana Kumar <chethana.kumar@enterprisedb.com> wrote:
Hi Murtuza,The changes are already incorporated so no worries :)Thanks,---Chethana kumarOn Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hello,As per discussion with Chethana, We need to make switch box color change for light and dark theme, Color details provided by Chethana is updated on ticket.--Regards,--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database CompanyP: +91 86981 57146
Let us discuss on a call for better clarity and the conclusion part we can put it on mail.
---
Chethana kumar
On Wed, Mar 18, 2020 at 2:12 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Chethana,No it is not, As per current dark theme implementation we have used primary color '#1a522b' for switch but the color you suggested is '#43A047' for both theme.--Regards,On Wed, Mar 18, 2020 at 2:06 PM Chethana Kumar <chethana.kumar@enterprisedb.com> wrote:Hi Murtuza,The changes are already incorporated so no worries :)Thanks,---Chethana kumarOn Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hello,As per discussion with Chethana, We need to make switch box color change for light and dark theme, Color details provided by Chethana is updated on ticket.--Regards,--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database CompanyP: +91 86981 57146
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation
The Postgres Database Company
P: +91 86981 57146
Hi Murtuza/Chethana,
Irrespective of what color you suggest, there is no need to add new variables for switch buttons. It should use success for on and ternary for off.
Having a separate green color for each and every control is absurd. If the green changes, it should change for all.
On Wed, Mar 18, 2020 at 2:24 PM Chethana Kumar <chethana.kumar@enterprisedb.com> wrote:
Let us discuss on a call for better clarity and the conclusion part we can put it on mail.---Chethana kumarOn Wed, Mar 18, 2020 at 2:12 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi Chethana,No it is not, As per current dark theme implementation we have used primary color '#1a522b' for switch but the color you suggested is '#43A047' for both theme.--Regards,On Wed, Mar 18, 2020 at 2:06 PM Chethana Kumar <chethana.kumar@enterprisedb.com> wrote:Hi Murtuza,The changes are already incorporated so no worries :)Thanks,---Chethana kumarOn Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hello,As per discussion with Chethana, We need to make switch box color change for light and dark theme, Color details provided by Chethana is updated on ticket.--Regards,--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database CompanyP: +91 86981 57146--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database CompanyP: +91 86981 57146
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Hello,
PFA updated patch with new colors provided by Chethana, As discussed we will be using the same primary success color in both theme so we don't have add new variable.
--
Regards,
On Wed, Mar 18, 2020 at 2:27 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Murtuza/Chethana,Irrespective of what color you suggest, there is no need to add new variables for switch buttons. It should use success for on and ternary for off.Having a separate green color for each and every control is absurd. If the green changes, it should change for all.On Wed, Mar 18, 2020 at 2:24 PM Chethana Kumar <chethana.kumar@enterprisedb.com> wrote:Let us discuss on a call for better clarity and the conclusion part we can put it on mail.---Chethana kumarOn Wed, Mar 18, 2020 at 2:12 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi Chethana,No it is not, As per current dark theme implementation we have used primary color '#1a522b' for switch but the color you suggested is '#43A047' for both theme.--Regards,On Wed, Mar 18, 2020 at 2:06 PM Chethana Kumar <chethana.kumar@enterprisedb.com> wrote:Hi Murtuza,The changes are already incorporated so no worries :)Thanks,---Chethana kumarOn Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hello,As per discussion with Chethana, We need to make switch box color change for light and dark theme, Color details provided by Chethana is updated on ticket.--Regards,--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database CompanyP: +91 86981 57146--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database CompanyP: +91 86981 57146--Thanks and Regards,Aditya ToshniwalpgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"
Attachment
Hi Murtuza,
The patch looks good to me.
On Thu, Mar 19, 2020 at 12:10 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hello,PFA updated patch with new colors provided by Chethana, As discussed we will be using the same primary success color in both theme so we don't have add new variable.--Regards,On Wed, Mar 18, 2020 at 2:27 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Murtuza/Chethana,Irrespective of what color you suggest, there is no need to add new variables for switch buttons. It should use success for on and ternary for off.Having a separate green color for each and every control is absurd. If the green changes, it should change for all.On Wed, Mar 18, 2020 at 2:24 PM Chethana Kumar <chethana.kumar@enterprisedb.com> wrote:Let us discuss on a call for better clarity and the conclusion part we can put it on mail.---Chethana kumarOn Wed, Mar 18, 2020 at 2:12 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi Chethana,No it is not, As per current dark theme implementation we have used primary color '#1a522b' for switch but the color you suggested is '#43A047' for both theme.--Regards,On Wed, Mar 18, 2020 at 2:06 PM Chethana Kumar <chethana.kumar@enterprisedb.com> wrote:Hi Murtuza,The changes are already incorporated so no worries :)Thanks,---Chethana kumarOn Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hello,As per discussion with Chethana, We need to make switch box color change for light and dark theme, Color details provided by Chethana is updated on ticket.--Regards,--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database CompanyP: +91 86981 57146--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database CompanyP: +91 86981 57146--Thanks and Regards,Aditya ToshniwalpgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Thanks, patch applied.
On Thu, Mar 19, 2020 at 12:10 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hello,PFA updated patch with new colors provided by Chethana, As discussed we will be using the same primary success color in both theme so we don't have add new variable.--Regards,On Wed, Mar 18, 2020 at 2:27 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Murtuza/Chethana,Irrespective of what color you suggest, there is no need to add new variables for switch buttons. It should use success for on and ternary for off.Having a separate green color for each and every control is absurd. If the green changes, it should change for all.On Wed, Mar 18, 2020 at 2:24 PM Chethana Kumar <chethana.kumar@enterprisedb.com> wrote:Let us discuss on a call for better clarity and the conclusion part we can put it on mail.---Chethana kumarOn Wed, Mar 18, 2020 at 2:12 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi Chethana,No it is not, As per current dark theme implementation we have used primary color '#1a522b' for switch but the color you suggested is '#43A047' for both theme.--Regards,On Wed, Mar 18, 2020 at 2:06 PM Chethana Kumar <chethana.kumar@enterprisedb.com> wrote:Hi Murtuza,The changes are already incorporated so no worries :)Thanks,---Chethana kumarOn Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hello,As per discussion with Chethana, We need to make switch box color change for light and dark theme, Color details provided by Chethana is updated on ticket.--Regards,--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database CompanyP: +91 86981 57146--Chethana KumarPrincipal UI/UX DesignerEnterpriseDB CorporationThe Postgres Database CompanyP: +91 86981 57146--Thanks and Regards,Aditya ToshniwalpgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246