Thread: [pgAdmin][RM4552] Dragging the selected text in SQL editor throwsconsole errors
[pgAdmin][RM4552] Dragging the selected text in SQL editor throwsconsole errors
From
Aditya Toshniwal
Date:
Hi Hackers,
Attached is the patch to fix the issue where dragging a selected text in SQL editor throws console errors and does not move the text.
As an improvement, the patch also fixes a potential issue where importing jquery.event.drag will override drag events and will break drag and drop feature. Currently jquery.event.drag is not imported. Changes are made to use vanilla addEventListener instead of jquery on() to attach drag related events to avoid conflict.
Kindly review.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachment
Re: [pgAdmin][RM4552] Dragging the selected text in SQL editor throwsconsole errors
From
Dave Page
Date:
Thanks, patch applied.
On Fri, Aug 2, 2019 at 6:25 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,Attached is the patch to fix the issue where dragging a selected text in SQL editor throws console errors and does not move the text.As an improvement, the patch also fixes a potential issue where importing jquery.event.drag will override drag events and will break drag and drop feature. Currently jquery.event.drag is not imported. Changes are made to use vanilla addEventListener instead of jquery on() to attach drag related events to avoid conflict.Kindly review.--Thanks and Regards,Aditya ToshniwalSoftware Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Re: [pgAdmin][RM4552] Dragging the selected text in SQL editor throwsconsole errors
From
Aditya Toshniwal
Date:
Hi Hackers,
This seemed to have disabled the drag drop feature. Attached is a minor fix to reenable it.
On Fri, Aug 2, 2019 at 3:59 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks, patch applied.On Fri, Aug 2, 2019 at 6:25 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Hackers,Attached is the patch to fix the issue where dragging a selected text in SQL editor throws console errors and does not move the text.As an improvement, the patch also fixes a potential issue where importing jquery.event.drag will override drag events and will break drag and drop feature. Currently jquery.event.drag is not imported. Changes are made to use vanilla addEventListener instead of jquery on() to attach drag related events to avoid conflict.Kindly review.--Thanks and Regards,Aditya ToshniwalSoftware Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachment
Re: [pgAdmin][RM4552] Dragging the selected text in SQL editor throwsconsole errors
From
Akshay Joshi
Date:
Thanks patch applied.
On Mon, Aug 12, 2019 at 12:22 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,This seemed to have disabled the drag drop feature. Attached is a minor fix to reenable it.On Fri, Aug 2, 2019 at 3:59 PM Dave Page <dpage@pgadmin.org> wrote:Thanks, patch applied.On Fri, Aug 2, 2019 at 6:25 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Hackers,Attached is the patch to fix the issue where dragging a selected text in SQL editor throws console errors and does not move the text.As an improvement, the patch also fixes a potential issue where importing jquery.event.drag will override drag events and will break drag and drop feature. Currently jquery.event.drag is not imported. Changes are made to use vanilla addEventListener instead of jquery on() to attach drag related events to avoid conflict.Kindly review.--Thanks and Regards,Aditya ToshniwalSoftware Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Thanks and Regards,Aditya ToshniwalSoftware Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246