[pgAdmin][RM4552] Dragging the selected text in SQL editor throwsconsole errors - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject [pgAdmin][RM4552] Dragging the selected text in SQL editor throwsconsole errors
Date
Msg-id CAM9w-_=3L1AbnTm8+Mi5M2Z1_QK04a+2SVADQmy5HQVnWaXwSg@mail.gmail.com
Whole thread Raw
Responses Re: [pgAdmin][RM4552] Dragging the selected text in SQL editor throwsconsole errors  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Hi Hackers,

Attached is the patch to fix the issue where dragging a selected text in SQL editor throws console errors and does not move the text.

As an improvement, the patch also fixes a potential issue where importing jquery.event.drag will override drag events and will break drag and drop feature. Currently jquery.event.drag is not imported. Changes are made to use vanilla addEventListener instead of jquery on() to attach drag related events to avoid conflict.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachment

pgadmin-hackers by date:

Previous
From: Yosry Muhammad
Date:
Subject: Ensure View Data mode fetches next rows on scrolling through resultswhen appropriate. Fixes #4536.
Next
From: Akshay Joshi
Date:
Subject: Re: [RM#4546] Add RE-SQL tests for Column node