Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][RM4552] Dragging the selected text in SQL editor throwsconsole errors - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin][RM4552] Dragging the selected text in SQL editor throwsconsole errors
Date
Msg-id CA+OCxoxazBG15YnF8_6kZM1DdnsoRLTzo7Rvo4GE3UaeGJKfWA@mail.gmail.com
Whole thread Raw
In response to [pgAdmin][RM4552] Dragging the selected text in SQL editor throwsconsole errors  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Responses Re: [pgAdmin][RM4552] Dragging the selected text in SQL editor throwsconsole errors  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
List pgadmin-hackers
Tree view
Thanks, patch applied.

On Fri, Aug 2, 2019 at 6:25 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix the issue where dragging a selected text in SQL editor throws console errors and does not move the text.

As an improvement, the patch also fixes a potential issue where importing jquery.event.drag will override drag events and will break drag and drop feature. Currently jquery.event.drag is not imported. Changes are made to use vanilla addEventListener instead of jquery on() to attach drag related events to avoid conflict.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Fix some errors thrown on the JS console when draggin
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Add various make targets for auditing the Python and